feat(Schematics): Rename default action type for action blueprint #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1040 BREAKING CHANGE: The action blueprint has been updated to be less generic, with associated reducer and effects updated for the feature blueprint BEFORE: export enum UserActionTypes { UserAction = '[User] Action' } export class User implements Action { readonly type = UserActionTypes.UserAction; } export type UserActions = User; AFTER: export enum UserActionTypes { LoadUsers = '[User] Load Users' } export class LoadUsers implements Action { readonly type = UserActionTypes.LoadUsers; } export type UserActions = LoadUsers;
brandonroberts
changed the title
| @@ -6,7 +6,7 @@ import { Actions, Effect } from '@ngrx/effects'; | |||
| export class <%= classify(name) %>Effects { | |||
| <% if(feature) { %> | |||
| @Effect() | |||
| effect$ = this.actions$.ofType(<%= classify(name) %>ActionTypes.<%= classify(name) %>Action); | |||
| effect$ = this.actions$.ofType(<%= classify(name) %>ActionTypes.Load<%= classify(name) %>s); | |||
There was a problem hiding this comment.
@brandonroberts - you may want to add this:
loadEffect$ = this.actions$.ofType(<%= classify(name) %>ActionTypes.Load<%= classify(name) %>s);
| } | ||
|
|
||
| export type <%= classify(name) %>Actions = <%= classify(name) %>; | ||
| export type <%= classify(name) %>Actions = Load<%= classify(name) %>s; |
There was a problem hiding this comment.
@brandonroberts - in the nx schematics, we generate scaffolding for both Load and Loaded and LoadError. And we use union types for the Load/Loaded actions.
e.g.
export type <%= classify(name) %>Actions =
Load<%= classify(name) %>s |
<%= classify(name) %>sLoaded |
<%= classify(name) %>sLoadError;Nx is also missing the
ssuffix... which I will add/fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1040
BREAKING CHANGE:
The action blueprint has been updated to be less generic, with associated reducer and effects updated for the feature blueprint
BEFORE:
export enum UserActionTypes {
UserAction = '[User] Action'
}
export class User implements Action {
readonly type = UserActionTypes.UserAction;
}
export type UserActions = User;
AFTER:
export enum UserActionTypes {
LoadUsers = '[User] Load Users'
}
export class LoadUsers implements Action {
readonly type = UserActionTypes.LoadUsers;
}
export type UserActions = LoadUsers;